Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures snapwm vinyl transactional state is cleared after a transaction completes so that recovery paths can safely call txn_begin under FD_PARANOID without tripping “already in txn” assertions.
Changes:
- Clear
ctx->vinyl.txn_activeafterfd_snapwm_vinyl_txn_commit. - Clear
ctx->vinyl.txn_activeafterfd_snapwm_vinyl_txn_cancel.
You can also share your feedback on Copilot code review. Take the survey.
jvarela-jump
force-pushed
the
jvarela/snapwm-txn-active-zero
branch
from
37f41d1 to
0347066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
snapwm,txn_activemust be zeroed aftertxn_commitortxn_cancel, otherwise callingtxn_beginduring recovery would trigger the following line if FD_PARANOID was set: